[PATCH] D22726: [DAGCombine] Match shift amount by value rather than relying on common sub-expressions.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D22726#637845, @bryant wrote:

> Just an (overdue) update: I've fixed this with Sanjay about two months ago in https://reviews.llvm.org/D25913 . That particular InstCombine allows (IR similar to) the cases in this patch to completely dodge the faulty SelectionDAG transform that generates SETCCs of the wrong width.
>
> Simon: You've mentioned wanting to keep the tests. Is this still the case? Otherwise, I think this thread can be closed.


If its been handled in InstCombine and you avoid the issue arising then I'm happy for this patch to be abandoned.


Repository:
  rL LLVM

https://reviews.llvm.org/D22726