[PATCH] D22726: [DAGCombine] Match shift amount by value rather than relying on common sub-expressions.

bryant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 06:23:11 PST 2017


bryant added a comment.

Just an (overdue) update: I've fixed this with Sanjay about two months ago in https://reviews.llvm.org/D25913 . That particular InstCombine allows (IR similar to) the cases in this patch to completely dodge the faulty SelectionDAG transform that generates SETCCs of the wrong width.

Simon: You've mentioned wanting to keep the tests. Is this still the case? Otherwise, I think this thread can be closed.


Repository:
  rL LLVM

https://reviews.llvm.org/D22726





More information about the llvm-commits mailing list