[PATCH] D28244: [ubsan] Minimize size of data for type_mismatch (Redo of D19668)

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 15:02:16 PST 2017


This ends up being a versioning system. By renaming the symbols we ensure
we fail loudly when mixing code from previous clang versions, since they're
not compatible.

Thank you,

 Filipe

On Thu, 5 Jan 2017 at 21:46, Vitaly Buka via Phabricator <
reviews at reviews.llvm.org> wrote:

> vitalybuka added inline comments.
>
>
>
>
>
> ================
>
> Comment at: lib/ubsan/ubsan_handlers.h:40
>
>  /// type.
>
> -RECOVERABLE(type_mismatch, TypeMismatchData *Data, ValueHandle Pointer)
>
> +RECOVERABLE(type_mismatch_v1, TypeMismatchData *Data, ValueHandle Pointer)
>
>
>
> ----------------
>
> why do you need to rename this?
>
>
>
>
>
> https://reviews.llvm.org/D28244
>
>
>
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170105/cc68f6c2/attachment.html>


More information about the llvm-commits mailing list