<div>This ends up being a versioning system. By renaming the symbols we ensure we fail loudly when mixing code from previous clang versions, since they're not compatible.</div><div><br></div><div>Thank you,</div><div><br></div><div> Filipe</div><div><br><div class="gmail_quote"><div>On Thu, 5 Jan 2017 at 21:46, Vitaly Buka via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vitalybuka added inline comments.<br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br>================<br class="gmail_msg"><br>Comment at: lib/ubsan/ubsan_handlers.h:40<br class="gmail_msg"><br> /// type.<br class="gmail_msg"><br>-RECOVERABLE(type_mismatch, TypeMismatchData *Data, ValueHandle Pointer)<br class="gmail_msg"><br>+RECOVERABLE(type_mismatch_v1, TypeMismatchData *Data, ValueHandle Pointer)<br class="gmail_msg"><br><br class="gmail_msg"><br>----------------<br class="gmail_msg"><br>why do you need to rename this?<br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br><a href="https://reviews.llvm.org/D28244" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28244</a><br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br></blockquote></div></div>