[PATCH] D28169: [ThinLTO] Subsume all importing checks into a single flag

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D28169#636490, @mehdi_amini wrote:

> LGTM, but have you checked that the number of imports is unchanged on a few apps with this?


Just confirmed they are the same for SPEC benchmarks gcc and xalancbmk.



================
Comment at: lib/Transforms/Utils/FunctionImportUtils.cpp:89
+#ifdef NDEBUG
+  assert(false && "Used set not computed in NDEBUG mode");
+#endif
----------------
mehdi_amini wrote:
> Assert are compiled out in NDEBUG mode, I think it won't do anything.
> 
> You may compile out this function entirely in `#ifndef NDEBUG` (and its declaration) so it can't be called.
Good point. I changed to compile out the function completely under NDEBUG.


https://reviews.llvm.org/D28169