[PATCH] D28169: [ThinLTO] Subsume all importing checks into a single flag

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

LGTM, but have you checked that the number of imports is unchanged on a few apps with this?



================
Comment at: lib/Transforms/Utils/FunctionImportUtils.cpp:89
+#ifdef NDEBUG
+  assert(false && "Used set not computed in NDEBUG mode");
+#endif
----------------
Assert are compiled out in NDEBUG mode, I think it won't do anything.

You may compile out this function entirely in `#ifndef NDEBUG` (and its declaration) so it can't be called.


https://reviews.llvm.org/D28169