[PATCH] D27991: Optimize objdump -objc-meta-data

[Dave Lee via Phabricator via llvm-commits]

kastiglione added inline comments.


================
Comment at: lib/Object/MachOObjectFile.cpp:2827
+  assert(
+      (Opcodes.data() == Other.Opcodes.data() || Opcodes == Other.Opcodes) &&
+      "compare iterators of different files");
----------------
compnerd wrote:
> Why not just change this to:
> 
>     assert(Opcodes.data() == Other.Opcodes.data() && Opcodes.size() == Other.Opcodes.size() && "comparing differing opcodes");
The current assertion has value semantics, this change would switch the assertion to allow reference equality only. I'm not sure why the assertion is currently constructed the way it is. I don't think any of llvm would break, but some external code could in theory. If you think it's best to change, I'll go with it.


https://reviews.llvm.org/D27991