[PATCH] D27991: Optimize objdump -objc-meta-data

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 11:54:33 PST 2017


compnerd added inline comments.


================
Comment at: lib/Object/MachOObjectFile.cpp:2827
+  assert(
+      (Opcodes.data() == Other.Opcodes.data() || Opcodes == Other.Opcodes) &&
+      "compare iterators of different files");
----------------
Why not just change this to:

    assert(Opcodes.data() == Other.Opcodes.data() && Opcodes.size() == Other.Opcodes.size() && "comparing differing opcodes");


https://reviews.llvm.org/D27991





More information about the llvm-commits mailing list