[PATCH] D28083: Add an index for Module Metadata record in the bitcode

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini marked 2 inline comments as done.
mehdi_amini added inline comments.


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1938
+  // fixed size from the current bit number to get the location to backpatch.
+  uint64_t BeginBlockBitPos = Stream.GetCurrentBitNo();
+
----------------
tejohnson wrote:
> tejohnson wrote:
> > Not the beginning of the block, so variable name should be changed.
> See this comment from earlier. Maybe IndexOffsetRecordBitPos?
Sorry, missed it! Fixed before pushing.


https://reviews.llvm.org/D28083