[PATCH] D28083: Add an index for Module Metadata record in the bitcode

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with a couple nits below.



================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1938
+  // fixed size from the current bit number to get the location to backpatch.
+  uint64_t BeginBlockBitPos = Stream.GetCurrentBitNo();
+
----------------
tejohnson wrote:
> Not the beginning of the block, so variable name should be changed.
See this comment from earlier. Maybe IndexOffsetRecordBitPos?


================
Comment at: llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp:608
 
+      // If we found a the metadata index, let's verify that we had an offset
+      // and its position!
----------------
nit: "a the"


https://reviews.llvm.org/D28083