[PATCH] D28103: Use TarWriter to create tar archives instead of cpio.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lld/COFF/Driver.cpp:463
     SmallString<64> Path = StringRef(Arg->getValue());
     sys::path::append(Path, "repro");
+
----------------
ruiu wrote:
> pcc wrote:
> > `"repro.tar"` here?
> I think on Windows it is more natural to not specify a file extension, unlike Unix.
I wasn't suggesting a functional change. `/linkrepro` takes a directory path to which you are appending `repro` here and `.tar` on lines 466 and 472, so you could just append `repro.tar` here.


https://reviews.llvm.org/D28103