[PATCH] D28103: Use TarWriter to create tar archives instead of cpio.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 25 01:53:02 PST 2016


ruiu added inline comments.


================
Comment at: lld/COFF/Driver.cpp:463
     SmallString<64> Path = StringRef(Arg->getValue());
     sys::path::append(Path, "repro");
+
----------------
pcc wrote:
> `"repro.tar"` here?
I think on Windows it is more natural to not specify a file extension, unlike Unix.


https://reviews.llvm.org/D28103





More information about the llvm-commits mailing list