[PATCH] D28049: [ELF] - Use error() instead of fatal() during relaxation of R_X86_64_GOTTPOFF

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 02:16:54 PST 2016


davide added a comment.

I guess this is OK once you address my comment.



================
Comment at: test/ELF/invalid/broken-relaxation-x64.s:1-8
+# REQUIRES: x86
+
+# RUN: yaml2obj %s -o %t.o
+# RUN: not ld.lld %t.o -o %t.exe 2>&1 | FileCheck --check-prefix=ERR %s
+# ERR: R_X86_64_GOTTPOFF must be used in MOVQ or ADDQ instructions only
+# ERR: R_X86_64_GOTTPOFF must be used in MOVQ or ADDQ instructions only
+
----------------
Please add a comment explaining how you generated this file (so that people unfamiliar with YAML can understand).


https://reviews.llvm.org/D28049





More information about the llvm-commits mailing list