[PATCH] D28049: [ELF] - Use error() instead of fatal() during relaxation of R_X86_64_GOTTPOFF

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: ruiu, rafael, davide.
grimar added subscribers: llvm-commits, grimar, evgeny777.

This is last known noticable fatal() in target.cpp.
We also have other ones for unknown relocations or
creating unknown targets, but that one can be just error I think.

Used yaml2obj to generate test.


https://reviews.llvm.org/D28049

Files:
  ELF/Target.cpp
  test/ELF/invalid/Inputs/broken-relaxation-x64.elf
  test/ELF/invalid/broken-relaxation-x64.s


Index: test/ELF/invalid/broken-relaxation-x64.s
===================================================================
--- test/ELF/invalid/broken-relaxation-x64.s
+++ test/ELF/invalid/broken-relaxation-x64.s
@@ -0,0 +1,42 @@
+# REQUIRES: x86
+
+# RUN: yaml2obj %s -o %t.o
+# RUN: not ld.lld %t.o -o %t.exe 2>&1 | FileCheck --check-prefix=ERR %s
+# ERR: R_X86_64_GOTTPOFF must be used in MOVQ or ADDQ instructions only
+# ERR: R_X86_64_GOTTPOFF must be used in MOVQ or ADDQ instructions only
+
+!ELF
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  OSABI:           ELFOSABI_FREEBSD
+  Type:            ET_REL
+  Machine:         EM_X86_64
+Sections:
+  - Type:            SHT_PROGBITS
+    Name:            .text
+    Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
+    AddressAlign:    0x04
+    Content:         "FFFFFFFFFFFFFFFF"
+  - Type:            SHT_PROGBITS
+    Name:            .tls
+    Flags:           [ SHF_ALLOC, SHF_TLS ]
+  - Type:            SHT_REL
+    Name:            .rel.text
+    Link:            .symtab
+    Info:            .text
+    AddressAlign:    0x04
+    Relocations:
+      - Offset:          4
+        Symbol:          foo
+        Type:            R_X86_64_GOTTPOFF
+      - Offset:          4
+        Symbol:          foo
+        Type:            R_X86_64_GOTTPOFF
+Symbols:
+  Global:
+    - Name:     foo
+      Type:     STT_TLS
+      Section:  .text
+      Value:    0x12345
+      Size:     4
Index: ELF/Target.cpp
===================================================================
--- ELF/Target.cpp
+++ ELF/Target.cpp
@@ -799,7 +799,7 @@
     memcpy(Inst, "\x48\xc7", 2);
     *RegSlot = 0xc0 | Reg;
   } else {
-    fatal(getErrorLocation(Loc - 3) +
+    error(getErrorLocation(Loc - 3) +
           "R_X86_64_GOTTPOFF must be used in MOVQ or ADDQ instructions only");
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28049.82318.patch
Type: text/x-patch
Size: 1857 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161222/63bfef7b/attachment.bin>