[PATCH] D27963: [Codegen] Have the generic debug skip functions return true on empty.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In https://reviews.llvm.org/D27963#628107, @iteratee wrote:

> In https://reviews.llvm.org/D27963#627614, @fhahn wrote:
>
> > `skipDebugInstructionsForward/Backward` take the iterator by value and return the advanced iterator again, because it seemed more in line with C++'s iterator functions (like next and prev), @MatzeB suggested that in   https://reviews.llvm.org/D27782#623009 .
>
>
> Note that the standard also has ::advance(it, n) which works via side-effect, so the std can't decide one way or the other.


Oh yes of course! I guess it comes down to personal preference and that's not a call for me to make.


Repository:
  rL LLVM

https://reviews.llvm.org/D27963