[PATCH] D27963: [Codegen] Have the generic debug skip functions return true on empty.

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: lib/CodeGen/BranchFolding.cpp:1814
     if (TIB == TIE || FIB == FIE)
       break;
 
----------------
Seems like this ought to become
```
if (skipDebugInstructionsForward(TIB, TIE) ||
    skipDebugInstructionsForward(FIB, FIE))
  break;
```



================
Comment at: lib/CodeGen/IfConversion.cpp:624
       break;
-    FIB = skipDebugInstructionsForward(FIB, FIE);
-    if (FIB == FIE)
+    if(skipDebugInstructionsForward(FIB, FIE))
       break;
----------------
These two 'if's can be combined.  Or if you prefer to leave them as they are, that's fine too.  But put a space between 'if' and paren.


================
Comment at: lib/CodeGen/IfConversion.cpp:666
       break;
-    RFIE = skipDebugInstructionsForward(RFIE, RFIB);
-    if (RFIE == RFIB)
+    if (skipDebugInstructionsForward(RFIE, RFIB))
       break;
----------------
As above these could be combined if you like.


Repository:
  rL LLVM

https://reviews.llvm.org/D27963