[PATCH] D27997: [AMDGPU] Prevent spills before exec mask is restored
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 20 13:59:58 PST 2016
qcolombet added inline comments.
================
Comment at: include/llvm/Target/TargetInstrInfo.h:1515
+ /// a good insertion point.
+ virtual bool isPositionLike(const MachineInstr &MI) const {
+ return false;
----------------
For the comment, I would use the same terminology as MachineInstr::isPosition. Right now, the comment seems off compared to the function name.
Also, would it make sense to have this flag exposed in the TDs?
Repository:
rL LLVM
https://reviews.llvm.org/D27997
More information about the llvm-commits
mailing list