[PATCH] D27997: [AMDGPU] Prevent spills before exec mask is restored

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 13:39:37 PST 2016


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:3647-3650
+  if (!MI.isTerminator() && MI.modifiesRegister(AMDGPU::EXEC, TRI) &&
+      MI.getOpcode() != AMDGPU::COPY)
+    return true;
+  return false;
----------------
The modifiesRegister check should be last. This can also be simplified to return X instead of if (X) return true. You also might be able to combine this with isSchedulingBoundary


Repository:
  rL LLVM

https://reviews.llvm.org/D27997





More information about the llvm-commits mailing list