[llvm] r289705 - fix gcc warning about a superfluous ;

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 20:03:36 PST 2016


FWIW I find more active descriptions helpful (eg: "Remove superfluous
semicolon") - whenever I read "fix warning" or "suppress warning", I'm
usually curious enough to go and see how it was fixed. If the patch
describes what's done (& doesn't even have to mention that it was motivated
by a warning, etc - that doesn't usually matter to me if the change stands
well on its own) that's usually more important/meaningful/direct.

On Wed, Dec 14, 2016 at 12:44 PM Nico Weber via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: nico
> Date: Wed Dec 14 14:33:54 2016
> New Revision: 289705
>
> URL: http://llvm.org/viewvc/llvm-project?rev=289705&view=rev
> Log:
> fix gcc warning about a superfluous ;
>
> Modified:
>     llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
>
> Modified: llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h?rev=289705&r1=289704&r2=289705&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h (original)
> +++ llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h Wed Dec 14
> 14:33:54 2016
> @@ -72,7 +72,7 @@ namespace RuntimeMD {
>      const char PrintfInfo[]               = "amd.PrintfInfo";
>  // Prinf function call information
>      const char ArgActualAcc[]             = "amd.ArgActualAcc";
>  // The actual kernel argument access qualifier
>      const char ArgPointeeAlign[]          = "amd.ArgPointeeAlign";
> // Alignment of pointee type
> -  };
> +  }
>
>    namespace KernelArg {
>      enum Kind : uint8_t {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161220/9210303a/attachment.html>


More information about the llvm-commits mailing list