<div dir="ltr">FWIW I find more active descriptions helpful (eg: "Remove superfluous semicolon") - whenever I read "fix warning" or "suppress warning", I'm usually curious enough to go and see how it was fixed. If the patch describes what's done (& doesn't even have to mention that it was motivated by a warning, etc - that doesn't usually matter to me if the change stands well on its own) that's usually more important/meaningful/direct.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 14, 2016 at 12:44 PM Nico Weber via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nico<br class="gmail_msg">
Date: Wed Dec 14 14:33:54 2016<br class="gmail_msg">
New Revision: 289705<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=289705&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=289705&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
fix gcc warning about a superfluous ;<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h?rev=289705&r1=289704&r2=289705&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h?rev=289705&r1=289704&r2=289705&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h Wed Dec 14 14:33:54 2016<br class="gmail_msg">
@@ -72,7 +72,7 @@ namespace RuntimeMD {<br class="gmail_msg">
     const char PrintfInfo[]               = "amd.PrintfInfo";           // Prinf function call information<br class="gmail_msg">
     const char ArgActualAcc[]             = "amd.ArgActualAcc";         // The actual kernel argument access qualifier<br class="gmail_msg">
     const char ArgPointeeAlign[]          = "amd.ArgPointeeAlign";      // Alignment of pointee type<br class="gmail_msg">
-  };<br class="gmail_msg">
+  }<br class="gmail_msg">
<br class="gmail_msg">
   namespace KernelArg {<br class="gmail_msg">
     enum Kind : uint8_t {<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>