[PATCH] D27962: Get function start line number from DWARF info

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

This seems like it's doing way more work than necessary.  AFAICT each of the callers is already having to figure out the InlinedChain, which hands you a DIE for the function.  It might be the DIE you actually want, or it might have a DW_AT_specification or DW_AT_abstract_origin that is a reference to the DIE you actually want.  I can't see any reason to extract a name and then try to do a (possibly ambiguous) name search through the entire debug-info section.
Am I missing something?


https://reviews.llvm.org/D27962