[PATCH] D27962: Get function start line number from DWARF info

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:91
+  char* demangle_result = itaniumDemangle(FunctionName.c_str(),
+                                          demangle_func_buf, &buf_len, nullptr);
+  std::string demangled_func_name;
----------------
Why do you need to demangle the name here?


================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:105
+
+  for (size_t i = 0; i < CU->getNumDIEs(); ++i) {
+    const DWARFDie die = CU->getDIEAtIndex(i);
----------------
Shouldn't this be using accelerator tables if available?


https://reviews.llvm.org/D27962