[compiler-rt] r289690 - [sanitizer] intercept bstring functions, patch by Kuang-che Wu (https://reviews.llvm.org/D27659)

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 12:38:14 PST 2016


No objections!

On Thu, Dec 15, 2016 at 12:30 PM, Hans Wennborg <hans at chromium.org> wrote:

> That sounds like the right fix, but this had been broken for a while
> and we really need to unbreak things, so reverting back to green
> seemed like the right thing to do in the meantime.
>
> On Thu, Dec 15, 2016 at 12:24 PM, Kostya Serebryany <kcc at google.com>
> wrote:
> > eh, I wanted to just disable it on Mac...
> > Anyway, thanks!
> >
> > On Thu, Dec 15, 2016 at 12:22 PM, Hans Wennborg <hans at chromium.org>
> wrote:
> >>
> >> On Wed, Dec 14, 2016 at 11:10 AM, Kostya Serebryany via llvm-commits
> >> <llvm-commits at lists.llvm.org> wrote:
> >> > Author: kcc
> >> > Date: Wed Dec 14 13:10:17 2016
> >> > New Revision: 289690
> >> >
> >> > URL: http://llvm.org/viewvc/llvm-project?rev=289690&view=rev
> >> > Log:
> >> > [sanitizer] intercept bstring functions, patch by Kuang-che Wu
> >> > (https://reviews.llvm.org/D27659)
> >> >
> >> > Added:
> >> >     compiler-rt/trunk/test/asan/TestCases/Linux/bcmp_test.cc
> >> >     compiler-rt/trunk/test/asan/TestCases/Linux/bcopy_test.cc
> >> >     compiler-rt/trunk/test/asan/TestCases/Linux/bzero_test.cc
> >> > Modified:
> >> >     compiler-rt/trunk/lib/msan/msan_interceptors.cc
> >> >
> >> > compiler-rt/trunk/lib/sanitizer_common/sanitizer_
> common_interceptors.inc
> >> >
> >> > compiler-rt/trunk/lib/sanitizer_common/sanitizer_
> platform_interceptors.h
> >>
> >> Reverted in r289864, as it broke programs on Mac. See the code review
> >> for details.
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161215/d3f680ee/attachment.html>


More information about the llvm-commits mailing list