<div dir="ltr">No objections! </div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 15, 2016 at 12:30 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">That sounds like the right fix, but this had been broken for a while<br>
and we really need to unbreak things, so reverting back to green<br>
seemed like the right thing to do in the meantime.<br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, Dec 15, 2016 at 12:24 PM, Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> wrote:<br>
> eh, I wanted to just disable it on Mac...<br>
> Anyway, thanks!<br>
><br>
> On Thu, Dec 15, 2016 at 12:22 PM, Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>> wrote:<br>
>><br>
>> On Wed, Dec 14, 2016 at 11:10 AM, Kostya Serebryany via llvm-commits<br>
>> <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
>> > Author: kcc<br>
>> > Date: Wed Dec 14 13:10:17 2016<br>
>> > New Revision: 289690<br>
>> ><br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=289690&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=289690&view=rev</a><br>
>> > Log:<br>
>> > [sanitizer] intercept bstring functions, patch by Kuang-che Wu<br>
>> > (<a href="https://reviews.llvm.org/D27659" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D27659</a>)<br>
>> ><br>
>> > Added:<br>
>> >     compiler-rt/trunk/test/asan/<wbr>TestCases/Linux/bcmp_test.cc<br>
>> >     compiler-rt/trunk/test/asan/<wbr>TestCases/Linux/bcopy_test.cc<br>
>> >     compiler-rt/trunk/test/asan/<wbr>TestCases/Linux/bzero_test.cc<br>
>> > Modified:<br>
>> >     compiler-rt/trunk/lib/msan/<wbr>msan_interceptors.cc<br>
>> ><br>
>> > compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common_interceptors.inc<br>
>> ><br>
>> > compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>platform_interceptors.h<br>
>><br>
>> Reverted in r289864, as it broke programs on Mac. See the code review<br>
>> for details.<br>
><br>
><br>
</div></div></blockquote></div><br></div>