[llvm] r289372 - [X86][InstCombine] Teach InstCombineCalls to simplify demanded elements for scalar FMA intrinsics.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 11 00:08:27 PST 2016


Just commit them separately and you can make a note which commit added them
in the review log in case someone is trying to figure things out. Not a big
deal, just a reminder. =]

On Sun, Dec 11, 2016 at 12:05 AM Craig Topper <craig.topper at gmail.com>
wrote:

> Grr. I wrote the test cases but forgot to add the new files. Should I
> revert and add them or just commit them separately?
>
> ~Craig
>
> On Sun, Dec 11, 2016 at 12:01 AM, Chandler Carruth <chandlerc at google.com>
> wrote:
>
> No test case?
>
> On Sat, Dec 10, 2016 at 11:52 PM Craig Topper via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> Author: ctopper
> Date: Sun Dec 11 01:42:06 2016
> New Revision: 289372
>
> URL: http://llvm.org/viewvc/llvm-project?rev=289372&view=rev
> Log:
> [X86][InstCombine] Teach InstCombineCalls to simplify demanded elements
> for scalar FMA intrinsics.
>
> These intrinsics don't read the upper bits of their second and third
> inputs so we can try to simplify them.
>
> Modified:
>     llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp
>
> Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp?rev=289372&r1=289371&r2=289372&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp (original)
> +++ llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp Sun Dec 11
> 01:42:06 2016
> @@ -1777,6 +1777,14 @@ Instruction *InstCombiner::visitCallInst
>      break;
>    }
>
> +  case Intrinsic::x86_fma_vfmadd_ss:
> +  case Intrinsic::x86_fma_vfmsub_ss:
> +  case Intrinsic::x86_fma_vfnmadd_ss:
> +  case Intrinsic::x86_fma_vfnmsub_ss:
> +  case Intrinsic::x86_fma_vfmadd_sd:
> +  case Intrinsic::x86_fma_vfmsub_sd:
> +  case Intrinsic::x86_fma_vfnmadd_sd:
> +  case Intrinsic::x86_fma_vfnmsub_sd:
>    case Intrinsic::x86_avx512_mask_add_ss_round:
>    case Intrinsic::x86_avx512_mask_div_ss_round:
>    case Intrinsic::x86_avx512_mask_mul_ss_round:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161211/76be2532/attachment.html>


More information about the llvm-commits mailing list