<div dir="ltr">Just commit them separately and you can make a note which commit added them in the review log in case someone is trying to figure things out. Not a big deal, just a reminder. =]</div><br><div class="gmail_quote"><div dir="ltr">On Sun, Dec 11, 2016 at 12:05 AM Craig Topper <<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Grr. I wrote the test cases but forgot to add the new files. Should I revert and add them or just commit them separately?<div class="gmail_extra gmail_msg"></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><br clear="all" class="gmail_msg"><div class="gmail_msg"><div class="m_-3384396451057092677gmail_signature gmail_msg" data-smartmail="gmail_signature">~Craig</div></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg">
<br class="gmail_msg"><div class="gmail_quote gmail_msg">On Sun, Dec 11, 2016 at 12:01 AM, Chandler Carruth <span dir="ltr" class="gmail_msg"><<a href="mailto:chandlerc@google.com" class="gmail_msg" target="_blank">chandlerc@google.com</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">No test case?</div><div class="m_-3384396451057092677HOEnZb gmail_msg"><div class="m_-3384396451057092677h5 gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Sat, Dec 10, 2016 at 11:52 PM Craig Topper via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
Date: Sun Dec 11 01:42:06 2016<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
New Revision: 289372<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=289372&view=rev" rel="noreferrer" class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=289372&view=rev</a><br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
Log:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
[X86][InstCombine] Teach InstCombineCalls to simplify demanded elements for scalar FMA intrinsics.<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
These intrinsics don't read the upper bits of their second and third inputs so we can try to simplify them.<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
Modified:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
    llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp?rev=289372&r1=289371&r2=289372&view=diff" rel="noreferrer" class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp?rev=289372&r1=289371&r2=289372&view=diff</a><br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
==============================================================================<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp (original)<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp Sun Dec 11 01:42:06 2016<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
@@ -1777,6 +1777,14 @@ Instruction *InstCombiner::visitCallInst<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
     break;<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
   }<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
+  case Intrinsic::x86_fma_vfmadd_ss:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
+  case Intrinsic::x86_fma_vfmsub_ss:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
+  case Intrinsic::x86_fma_vfnmadd_ss:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
+  case Intrinsic::x86_fma_vfnmsub_ss:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
+  case Intrinsic::x86_fma_vfmadd_sd:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
+  case Intrinsic::x86_fma_vfmsub_sd:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
+  case Intrinsic::x86_fma_vfnmadd_sd:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
+  case Intrinsic::x86_fma_vfnmsub_sd:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
   case Intrinsic::x86_avx512_mask_add_ss_round:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
   case Intrinsic::x86_avx512_mask_div_ss_round:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
   case Intrinsic::x86_avx512_mask_mul_ss_round:<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
_______________________________________________<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
llvm-commits mailing list<br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="m_-3384396451057092677m_-4180877898077366551gmail_msg gmail_msg">
</blockquote></div>
</div></div></blockquote></div><br class="gmail_msg"></div></div></blockquote></div>