[PATCH] D26224: NewGVN

[Daniel Berlin via llvm-commits]

On Fri, Dec 9, 2016 at 6:54 PM, Marcello Maggioni via Phabricator <
reviews at reviews.llvm.org> wrote:

> kariddi added inline comments.
>
>
> ================
> Comment at: lib/Transforms/Scalar/NewGVN.cpp:1219
> +  ExpressionAllocator.Reset();
> +  CongruenceClasses.clear();
> +  ExpressionToClass.clear();
> ----------------
> This gets cleared, but the CongruenceClasses seem to be created through
> "new" and stored in the vector.
>



>
> Where do they get destroyed?
>
> This code got lost somewhere on the branch, but yes, it should be properly
deleting them, not just clear'ing.


>
> https://reviews.llvm.org/D26224
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161210/80298d21/attachment.html>