[PATCH] D26224: NewGVN

[Marcello Maggioni via Phabricator via llvm-commits]

kariddi added inline comments.


================
Comment at: lib/Transforms/Scalar/NewGVN.cpp:1330
+        bool BlockReachable = ReachableBlocks.count(CurrBlock);
+        const auto &InstRange = BlockInstRange.lookup(CurrBlock);
+
----------------
You are hiding the already defined variable of the same name above. This is slightly confusing while reading the code.

Consider changing this to CurrInstRange or the one above in TotalInstRange or something like that.


https://reviews.llvm.org/D26224