[PATCH] D27152: Merge strings using sharded hash tables.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 10 15:41:22 PST 2016


On Sat, Dec 10, 2016 at 2:51 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama <ruiu at google.com> writes:
> >
> > This means we produce different results with threads disabled?
> >
> >
> > Yes. But as long as you pass the same command line arguments, results are
> > the same.
>
> That is still undesirable. Using --no-threads is convenient for
> debugging and it makes it harder if that produces a different result.
>
>
This is basically a policy decision. Is `--threads`/`--no-threads` allowed
to affect the output? Whatever we decide, we should document the decision
because it has pretty profound consequences.

(although I think that our build ID already ends up different for
threads/no-threads?)

-- Sean Silva



> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161210/98b0439c/attachment.html>


More information about the llvm-commits mailing list