[PATCH] D27512: Move clang's ParseHelper into Support (llvm part)

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

Looking again at https://reviews.llvm.org/D27512, you're essentially re-implementing VerifyDiagnosticConsumer.cpp's `ParseDirective` (much of it with copy-paste). That seems really unfortunate. If we decide to change something in the `-verify` syntax, we'll now have multiple places to change. If there are bugs, there are multiple places to fix.

It must be possible to at least share the code that parses a comment and figures out what directives it contains, and ideally also the code that matches those directives against diagnostics.


Repository:
  rL LLVM

https://reviews.llvm.org/D27512