[PATCH] D27512: Move clang's ParseHelper into Support (llvm part)
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 9 10:39:04 PST 2016
hans added a comment.
What worries me is that we're parsing a ton of different kinds of files all over LLVM, but this ParserHelper still seems only useful for parsing `-verify` things. (For example, `SearchClosingBrace` seems very specific, and exposing `End`, `C`, and `P` seems like a very specialized interface.) So there's kind of mismatch between the name and what it's for.
Would it really be that hard to extract a generally useful `-verify` utility? Something that parses a file and digs out the expected strings and their positions? That seems like it would be really useful.
Repository:
rL LLVM
https://reviews.llvm.org/D27512
More information about the llvm-commits
mailing list