[PATCH] D27283: Fix invalid addrspacecast due to combining alloca with global var

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl marked 3 inline comments as done.
yaxunl added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:253-256
+      auto *NewI = GetElementPtrInst::Create(NT->getElementType(), V, Indices);
+      InsertNewInstWith(NewI, *GEP);
+      if (!replacePointer(*GEP, NewI))
+        return false;
----------------
majnemer wrote:
> Is it possible for you to create instructions which you never RAUW?
Yes, but then these instructions will be removed. The lit test checks that.


https://reviews.llvm.org/D27283