[PATCH] D27283: Fix invalid addrspacecast due to combining alloca with global var

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:2141-2142
   // global <-> flat are no-ops and never emitted.
+  DEBUG(dbgs() << "Invalid addrspacecast:\n";
+        ASC->dump());
 
----------------
arsenm wrote:
> yaxunl wrote:
> > arsenm wrote:
> > > This should be removed
> > I can keep it to myself but without this debug output it is much difficult to debug the "invalid addrspacecast" issue.
> It already produces an error here which is easy to track down
but it does not tell you what SDNode causes it. Even if you break into it you still need to dump it to know what happens.


https://reviews.llvm.org/D27283