[PATCH] D27458: [ELF] - Teach LLD to recognize PT_OPENBSD_BOOTDATA

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1862
                      .Case("PT_OPENBSD_WXNEEDED", PT_OPENBSD_WXNEEDED)
+                     .Case("PT_OPENBSD_BOOTDATA", PT_OPENBSD_BOOTDATA)
                      .Default(-1);
----------------
grimar wrote:
> ruiu wrote:
> > grimar wrote:
> > > ruiu wrote:
> > > > Sort.
> > > Sorted by value, like others entries.
> > But why? Probably nobody memorizes these numbers.
> Hmmm. For consistency. Whole StringSwitch is sorted by values.
> Also them are sorted in ELF.h in the same way and it is comfortable to compare missings if needed.
Consistency with ELF.h may make sense, though I'm tempted to sort them here. OK in either way.


https://reviews.llvm.org/D27458