[PATCH] D27458: [ELF] - Teach LLD to recognize PT_OPENBSD_BOOTDATA

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 08:37:06 PST 2016


grimar added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1862
                      .Case("PT_OPENBSD_WXNEEDED", PT_OPENBSD_WXNEEDED)
+                     .Case("PT_OPENBSD_BOOTDATA", PT_OPENBSD_BOOTDATA)
                      .Default(-1);
----------------
ruiu wrote:
> grimar wrote:
> > ruiu wrote:
> > > Sort.
> > Sorted by value, like others entries.
> But why? Probably nobody memorizes these numbers.
Hmmm. For consistency. Whole StringSwitch is sorted by values.
Also them are sorted in ELF.h in the same way and it is comfortable to compare missings if needed.


https://reviews.llvm.org/D27458





More information about the llvm-commits mailing list