[PATCH] D27375: Let ubsan search UBSAN_SYMBOLIZER_PATH for llvm-symbolizer

[Nico Weber via llvm-commits]

On the other hand, options are set via ASAN_OPTIONS, UBSAN_OPTIONS, etc,
not via some SANITIZER_OPTIONS var that all the sanitizers understand.
Currently, things are fairly consistent (and after this change, even more
so). Declaring the existing ASAN_SYMBOLIZER_PATH etc as deprecated,
introducing a new LLVM_SANITIZER_PATH thing (does gcc's asan use the
runtime in compiler-rt, or do they have their own runtime?), and adding
deprecation output introduces quite a bit of turmoil that'll take a release
or two (6-12 months) to settle down, and the state we get to isn't that
much better than where we are right now.

On Fri, Dec 2, 2016 at 7:45 PM, Evgeniy Stepanov via Phabricator <
reviews at reviews.llvm.org> wrote:

> eugenis added a comment.
>
> In https://reviews.llvm.org/D27375#612431, @pcc wrote:
>
> > In https://reviews.llvm.org/D27375#612426, @eugenis wrote:
> >
> > > I can imagine a separate environment variable being more convenient in
> some cases. I don't think we should deprecate it. Also, printing stuff can
> break user programs, so it should not be done by default, and doing it only
> with verbosity=1 is almost useless, no one will see it.
> >
> >
> > Maybe only do it if isatty(stdout)?
>
>
> This could work.
>
> >
> >
> >> I'd add LLVM_SYMBOLIZER_PATH, maybe add UBSAN_SYMBOLIZER_PATH (just for
> consistency), and change the docs to point to LLVM_SYMBOLIZER_PATH and
> external_symbolizer_path.
> >
> > Regarding UBSAN_SYMBOLIZER_PATH why add something for consistency with a
> deprecated env var?
>
> That's also true.
>
>
> https://reviews.llvm.org/D27375
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161202/54c21089/attachment.html>