[PATCH] D27375: Let ubsan search UBSAN_SYMBOLIZER_PATH for llvm-symbolizer

Fri Dec 2 16:45:32 PST 2016

eugenis added a comment.

In https://reviews.llvm.org/D27375#612431, @pcc wrote:

> In https://reviews.llvm.org/D27375#612426, @eugenis wrote:
>
> > I can imagine a separate environment variable being more convenient in some cases. I don't think we should deprecate it. Also, printing stuff can break user programs, so it should not be done by default, and doing it only with verbosity=1 is almost useless, no one will see it.
>
>
> Maybe only do it if isatty(stdout)?

This could work.

> 
> 
>> I'd add LLVM_SYMBOLIZER_PATH, maybe add UBSAN_SYMBOLIZER_PATH (just for consistency), and change the docs to point to LLVM_SYMBOLIZER_PATH and external_symbolizer_path.
> 
> Regarding UBSAN_SYMBOLIZER_PATH why add something for consistency with a deprecated env var?

That's also true.

https://reviews.llvm.org/D27375