[PATCH] D25136: [Triple] Add Facebook vendor

[Shoaib Meenai via llvm-commits]

Sorry about this. I completely missed your second email with further questions about the patch, so I thought I was good to commit. I'll respond to that separately.

From: llvm-commits <llvm-commits-bounces at lists.llvm.org> on behalf of Daniel Berlin via llvm-commits <llvm-commits at lists.llvm.org>
Reply-To: Daniel Berlin <dberlin at dberlin.org>
Date: Tuesday, November 22, 2016 at 12:05 PM
To: "reviews+D25136+public+2d072ddd23e04333 at reviews.llvm.org" <reviews+D25136+public+2d072ddd23e04333 at reviews.llvm.org>, "compnerd at compnerd.org" <compnerd at compnerd.org>
Cc: "dccitaliano at gmail.com" <dccitaliano at gmail.com>, "llvm-commits at lists.llvm.org" <llvm-commits at lists.llvm.org>
Subject: Re: [PATCH] D25136: [Triple] Add Facebook vendor

This is not okay. You need to respond to objections *before* you commit. Please revert.
On Tue, Nov 22, 2016, 11:47 AM Shoaib Meenai <smeenai at fb.com<mailto:smeenai at fb.com>> wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287684: [Triple] Add Facebook vendor (authored by smeenai).

Changed prior to commit:
  https://reviews.llvm.org/D25136?vs=73153&id=78910#toc<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D25136-3Fvs-3D73153-26id-3D78910-23toc&d=DgMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=HnCfaW3psf8PxrqKXgFJeGCqUTiu-Pc5P7iT9A6oziM&s=U95KDUbPoxwFmJxHXaLp9l2iW68qOzWulIWnlrrcCFA&e=>

Repository:
  rL LLVM

https://reviews.llvm.org/D25136<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D25136&d=DgMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=HnCfaW3psf8PxrqKXgFJeGCqUTiu-Pc5P7iT9A6oziM&s=gixBlrWxpg1gMlirOJFM0m32GX7Srasb0AJtPjeU_eg&e=>

Files:
  llvm/trunk/include/llvm/ADT/Triple.h
  llvm/trunk/lib/Support/Triple.cpp


Index: llvm/trunk/include/llvm/ADT/Triple.h
===================================================================
--- llvm/trunk/include/llvm/ADT/Triple.h
+++ llvm/trunk/include/llvm/ADT/Triple.h
@@ -130,6 +130,7 @@
     SCEI,
     BGP,
     BGQ,
+    Facebook,
     Freescale,
     IBM,
     ImaginationTechnologies,
Index: llvm/trunk/lib/Support/Triple.cpp
===================================================================
--- llvm/trunk/lib/Support/Triple.cpp
+++ llvm/trunk/lib/Support/Triple.cpp
@@ -152,6 +152,7 @@
   case SCEI: return "scei";
   case BGP: return "bgp";
   case BGQ: return "bgq";
+  case Facebook: return "facebook";
   case Freescale: return "fsl";
   case IBM: return "ibm";
   case ImaginationTechnologies: return "img";
@@ -434,6 +435,7 @@
     .Case("scei", Triple::SCEI)
     .Case("bgp", Triple::BGP)
     .Case("bgq", Triple::BGQ)
+    .Case("facebook", Triple::Facebook)
     .Case("fsl", Triple::Freescale)
     .Case("ibm", Triple::IBM)
     .Case("img", Triple::ImaginationTechnologies)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161203/ad914f3f/attachment.html>