<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Title" content="">
<meta name="Keywords" content="">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:Calibri;
color:windowtext;}
span.msoIns
{mso-style-type:export-only;
mso-style-name:"";
text-decoration:underline;
color:teal;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Calibri">Sorry about this. I completely missed your second email with further questions about the patch, so I thought I was good to commit. I'll respond to that separately.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Calibri"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-family:Calibri;color:black">From: </span>
</b><span style="font-family:Calibri;color:black">llvm-commits <llvm-commits-bounces@lists.llvm.org> on behalf of Daniel Berlin via llvm-commits <llvm-commits@lists.llvm.org><br>
<b>Reply-To: </b>Daniel Berlin <dberlin@dberlin.org><br>
<b>Date: </b>Tuesday, November 22, 2016 at 12:05 PM<br>
<b>To: </b>"reviews+D25136+public+2d072ddd23e04333@reviews.llvm.org" <reviews+D25136+public+2d072ddd23e04333@reviews.llvm.org>, "compnerd@compnerd.org" <compnerd@compnerd.org><br>
<b>Cc: </b>"dccitaliano@gmail.com" <dccitaliano@gmail.com>, "llvm-commits@lists.llvm.org" <llvm-commits@lists.llvm.org><br>
<b>Subject: </b>Re: [PATCH] D25136: [Triple] Add Facebook vendor<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt">This is not okay. You need to respond to objections *before* you commit. Please revert.<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Nov 22, 2016, 11:47 AM Shoaib Meenai <<a href="mailto:smeenai@fb.com">smeenai@fb.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL287684: [Triple] Add Facebook vendor (authored by smeenai).<br>
<br>
Changed prior to commit:<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D25136-3Fvs-3D73153-26id-3D78910-23toc&d=DgMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=HnCfaW3psf8PxrqKXgFJeGCqUTiu-Pc5P7iT9A6oziM&s=U95KDUbPoxwFmJxHXaLp9l2iW68qOzWulIWnlrrcCFA&e=" target="_blank">
https://reviews.llvm.org/D25136?vs=73153&id=78910#toc</a><br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D25136&d=DgMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=HnCfaW3psf8PxrqKXgFJeGCqUTiu-Pc5P7iT9A6oziM&s=gixBlrWxpg1gMlirOJFM0m32GX7Srasb0AJtPjeU_eg&e=" target="_blank">https://reviews.llvm.org/D25136</a><br>
<br>
Files:<br>
llvm/trunk/include/llvm/ADT/Triple.h<br>
llvm/trunk/lib/Support/Triple.cpp<br>
<br>
<br>
Index: llvm/trunk/include/llvm/ADT/Triple.h<br>
===================================================================<br>
--- llvm/trunk/include/llvm/ADT/Triple.h<br>
+++ llvm/trunk/include/llvm/ADT/Triple.h<br>
@@ -130,6 +130,7 @@<br>
SCEI,<br>
BGP,<br>
BGQ,<br>
+ Facebook,<br>
Freescale,<br>
IBM,<br>
ImaginationTechnologies,<br>
Index: llvm/trunk/lib/Support/Triple.cpp<br>
===================================================================<br>
--- llvm/trunk/lib/Support/Triple.cpp<br>
+++ llvm/trunk/lib/Support/Triple.cpp<br>
@@ -152,6 +152,7 @@<br>
case SCEI: return "scei";<br>
case BGP: return "bgp";<br>
case BGQ: return "bgq";<br>
+ case Facebook: return "facebook";<br>
case Freescale: return "fsl";<br>
case IBM: return "ibm";<br>
case ImaginationTechnologies: return "img";<br>
@@ -434,6 +435,7 @@<br>
.Case("scei", Triple::SCEI)<br>
.Case("bgp", Triple::BGP)<br>
.Case("bgq", Triple::BGQ)<br>
+ .Case("facebook", Triple::Facebook)<br>
.Case("fsl", Triple::Freescale)<br>
.Case("ibm", Triple::IBM)<br>
.Case("img", Triple::ImaginationTechnologies)<br>
<br>
<o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>