[PATCH] D27235: [libFuzzer] Diff 5 - Split FuzzerExtFunction implementation for Linux, Apple and Windows.

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added inline comments.


================
Comment at: lib/Fuzzer/FuzzerCorpus.h:17
 #include <unordered_set>
+#include <numeric>
 
----------------
kcc wrote:
> is this a related change? 
That header is required to include `std::iota()` declaration, in Windows. It is a detail, if you prefer, I can add that line in a different diff.
I apologize for these unrelated "details". This is the result of splitting a previous diff into many diffs.
Now that I understand how the review system works, I will be more careful with future diffs.


================
Comment at: lib/Fuzzer/FuzzerExtFunctionsDlsym.cpp:17
 #include "FuzzerExtFunctions.h"
+#include "FuzzerIO.h"
 #include <dlfcn.h>
----------------
kcc wrote:
> do you need this change here? 
@kcc Yes, it is needed to use the `Printf()` function.


================
Comment at: lib/Fuzzer/FuzzerExtFunctionsWeak.cpp:16
 #include "FuzzerDefs.h"
 #if LIBFUZZER_LINUX
 #include "FuzzerExtFunctions.h"
----------------
kcc wrote:
> do you need this change here? 
@kcc  I remove an empty line, so the 3 files `FuzzerExtFunctions*.cpp` have the same format. If you prefer, I can remove that change.


================
Comment at: lib/Fuzzer/FuzzerExtFunctionsWeakAlias.cpp:9
+//===----------------------------------------------------------------------===//
+// Implementation for Windows.
+//===----------------------------------------------------------------------===//
----------------
kcc wrote:
> Implementation using weak aliases. Works for Windows. 
@kcc Ok, I will add that comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D27235