[PATCH] D27235: [libFuzzer] Diff 5 - Split FuzzerExtFunction implementation for Linux, Apple and Windows.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: lib/Fuzzer/FuzzerCorpus.h:17
 #include <unordered_set>
+#include <numeric>
 
----------------
is this a related change? 


================
Comment at: lib/Fuzzer/FuzzerExtFunctionsDlsym.cpp:17
 #include "FuzzerExtFunctions.h"
+#include "FuzzerIO.h"
 #include <dlfcn.h>
----------------
do you need this change here? 


================
Comment at: lib/Fuzzer/FuzzerExtFunctionsWeak.cpp:16
 #include "FuzzerDefs.h"
 #if LIBFUZZER_LINUX
 #include "FuzzerExtFunctions.h"
----------------
do you need this change here? 


================
Comment at: lib/Fuzzer/FuzzerExtFunctionsWeakAlias.cpp:9
+//===----------------------------------------------------------------------===//
+// Implementation for Windows.
+//===----------------------------------------------------------------------===//
----------------
Implementation using weak aliases. Works for Windows. 


Repository:
  rL LLVM

https://reviews.llvm.org/D27235