[PATCH] D27320: [DWARF] Put linkage-name on abstract origin even when there's a declaration

[David Blaikie via llvm-commits]

Reading the actual code - I'm now a bit confused. It looks like it's
duplicating the linkage name but I thought the patch description was saying
it was missing from the declaration.

I'm confused.

On Thu, Dec 1, 2016 at 1:44 PM Paul Robinson via Phabricator <
reviews at reviews.llvm.org> wrote:

> probinson added inline comments.
>
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1162
>                        "getOrCreateSubprogramDIE");
> -    DeclLinkageName = SPDecl->getLinkageName();
> +    DeclLinkageName = getDieLinkageName(DeclDie);
>      unsigned DeclID =
> ----------------
> I had thought about making this
> ```
> if (DD->useAllLinkageNames())
>   DeclLinkageName = SPDecl->getLinkageName();
> ```
> and so not needing the extra static function, but actually looking into
> the DIE itself seemed more robust.
>
>
> https://reviews.llvm.org/D27320
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161201/fa68ee50/attachment.html>