[PATCH] D27320: [DWARF] Put linkage-name on abstract origin even when there's a declaration

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 13:44:42 PST 2016


probinson added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1162
                       "getOrCreateSubprogramDIE");
-    DeclLinkageName = SPDecl->getLinkageName();
+    DeclLinkageName = getDieLinkageName(DeclDie);
     unsigned DeclID =
----------------
I had thought about making this
```
if (DD->useAllLinkageNames())
  DeclLinkageName = SPDecl->getLinkageName();
```
and so not needing the extra static function, but actually looking into the DIE itself seemed more robust.


https://reviews.llvm.org/D27320





More information about the llvm-commits mailing list