[PATCH] D27242: Bitcode: Introduce BitcodeModule::{has, get}Summary().

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:6100
             return error("Invalid hash length " + Twine(Record.size()).str());
-          if (!TheIndex)
-            break;
----------------
pcc wrote:
> mehdi_amini wrote:
> > If `TheIndex` is no longer optional, we should make it a reference.
> Sure, I'll do that in a followup commit as it's a rather churny non-functional change.
Yes looks better split, thanks.


https://reviews.llvm.org/D27242