[PATCH] D27242: Bitcode: Introduce BitcodeModule::{has, get}Summary().

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 21:13:21 PST 2016


pcc added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:6100
             return error("Invalid hash length " + Twine(Record.size()).str());
-          if (!TheIndex)
-            break;
----------------
mehdi_amini wrote:
> If `TheIndex` is no longer optional, we should make it a reference.
Sure, I'll do that in a followup commit as it's a rather churny non-functional change.


https://reviews.llvm.org/D27242





More information about the llvm-commits mailing list