[PATCH] D27064: [SelectionDAG] Refactor TargetLowering::expandMUL (NFC)

[Nicolai Hähnle via llvm-commits]

nhaehnle added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:3110
+                          bool Signed) -> bool {
+    if ((Signed && HasUMUL_LOHI) || (!Signed && HasSMUL_LOHI)) {
+      Lo = DAG.getNode(Signed ? ISD::SMUL_LOHI : ISD::UMUL_LOHI, dl, VTs, L, R);
----------------
efriedma wrote:
> Did you mean "(Signed && HasSMUL_LOHI) || (!Signed && HasUMUL_LOHI)"?
Absolutely, thanks. Same in the if-statement below. The lit tests didn't pick this up, but I guess there aren't too many targets that have one but not the other.


https://reviews.llvm.org/D27064