[PATCH] D27064: [SelectionDAG] Refactor TargetLowering::expandMUL (NFC)

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 13:20:16 PST 2016


efriedma added a comment.

This is much easier to understand; thanks.



================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:3110
+                          bool Signed) -> bool {
+    if ((Signed && HasUMUL_LOHI) || (!Signed && HasSMUL_LOHI)) {
+      Lo = DAG.getNode(Signed ? ISD::SMUL_LOHI : ISD::UMUL_LOHI, dl, VTs, L, R);
----------------
Did you mean "(Signed && HasSMUL_LOHI) || (!Signed && HasUMUL_LOHI)"?


https://reviews.llvm.org/D27064





More information about the llvm-commits mailing list