[PATCH] D27012: [asan] Provide bug descriptions for all reports (not just ErrorGeneric)

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 12:04:14 PST 2016


kubabrecka added a comment.

> Well, it looks like it's not that redundant. If you look at the logic in ErrorGeneric, you see multiple calls to scariness.Scare, and that's where the complexity arises. I take it back, let's keep this separate.

ErrorGeneric constructs scariness strings like "8-byte-write-heap-buffer-overflow-far-from-bounds", which is the description of this bug instance, whereas what I'm looking for is a description of a whole class, for the purposes of categorization, e.g. "heap-buffer-overflow", "double-free", "odr-violation" and such.  So I slightly agree with you that this is a separate thing from the scariness description, but there's a lot of overlap.

So the previous patch looks good to you?


https://reviews.llvm.org/D27012





More information about the llvm-commits mailing list