[PATCH] D27012: [asan] Provide bug descriptions for all reports (not just ErrorGeneric)

[Reid Kleckner via llvm-commits]

rnk added a comment.

In https://reviews.llvm.org/D27012#604582, @filcab wrote:

> In https://reviews.llvm.org/D27012#604558, @rnk wrote:
>
> > Isn't this somewhat redundant with the buffer in ScarinessScoreBase?
> >
> >   struct ScarinessScoreBase {
> >     ...
> >     int score;
> >     char descr[1024];
> >   };
>
>
> I was going to ask the same. And we have more information in the scariness score (e.g: in the param-overlap, and generic errors).
>  Maybe converting all the scattered `bug_descr` to use the scariness score would be better?


Well, it looks like it's not that redundant. If you look at the logic in ErrorGeneric, you see multiple calls to scariness.Scare, and that's where the complexity arises. I take it back, let's keep this separate.


https://reviews.llvm.org/D27012