[PATCH] D26521: [X86] Allow folding of reloads from stack slots when loading a subreg of the spilled reg

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 15:47:07 PST 2016


mkuper added a comment.

In https://reviews.llvm.org/D26521#603360, @MatzeB wrote:

> What about changing `isSubregFoldable()` to not take any parameters and just return true/false, so all the decision logic can stay in `foldMemoryOperand()`?


Do you mean in the target's foldMemoryOperandImpl()? (The decision needs to be target-dependent)
If you do, I think that can work. Not sure it's going to be a net improvement, but I'll post a patch.


https://reviews.llvm.org/D26521





More information about the llvm-commits mailing list